Update image used for presto container

tagomoris / presto-client-node

Distributed query engine Presto client library for node.js

MIT License

126 stars 57 forks source link

Update image used for presto container #78

Closed MasterOdin closed 12 months ago

MasterOdin commented 1 year ago

PR updates the source used for the prestodb-sandbox image, as the existing one was deleted from Docker Hub. Earlier this year IBM acquired Ahana, and last week it looks like they completed deleted all resources that Ahana had on a number of sites, including Docker Hub.

The image replacing it with is the exact same image, just uploaded to a new place. In theory, at some point it should be possible to use the prestodb/presto images, but currently using them requires creating and mounting a number of etc/ config files, vs just having the image be self-contained.

tagomoris commented 1 year ago

I'm receiving notifications of changes, but now can't do any work because of a disaster of flu&covid-19 in my home. Let me check them days or a week later.

tagomoris commented 12 months ago

@MasterOdin CIs are failing. Do you have any idea why they're failing? Is it from any differences between images or other reasons?

MasterOdin commented 12 months ago

Sorry about the number of commits. The PR should now be ready. I had reworked how ghcr.io/popsql/prestodb-sandbox images were published to get linux/arm64 images built, but had introduced a bug in the Dockerfile that rendered the images broken and wouldn't properly start the DB. I've fixed that, and also updated the version used to test to one that has both linux/amd64 and linux/arm64 available (this is for 0.282+).

Should be ready to merge now.

tagomoris commented 12 months ago

Merged. Thank you for the replacement!