search

tagomoris / shib

WebUI for query engines: Hive and Presto
201 stars 59 forks source link

add query null check #31

Closed wyukawa closed 9 years ago

wyukawa commented 9 years ago

If you access shib API with non-existence queryid/resultid , the following TypeError occurs.

For, exapmle, if you access /download/tsv/:resultid with non-existence resultid, the following TypeError occurs.

/.../shib/app.js:573 res.set('X-Shib-Query-ID', query.queryid); ^ TypeError: Cannot read property 'queryid' of null at null. (/.../shib/app.js:573:37) at /.../shib/lib/shib/client.js:257:14 at Statement. (/.../shib/lib/shib/localdiskstore.js:162:17)

wyukawa commented 9 years ago

oh, exactly, I fixed. please review.

tagomoris commented 9 years ago

@wyukawa I added you to collaborator of this repository. Merging this p-r is your first job!

wyukawa commented 9 years ago

Merged!!!

tagomoris commented 9 years ago

Great job!

wyukawa commented 9 years ago

:smile: