Closed zerocstaker closed 3 years ago
Hi David,
Here is the result i have from running on the same example at my end.
recent reports have linked some france - based players with returns to wales . ` ` i ' ve always felt - and this is with my rugby hat on now ; this is not region or wru - i ' d rather spend that money on keeping players in wales , ' ' said davies . the wru provides # 2m to the fund and # 1 . 3 m comes from the regions . former wales and british and irish lions fly - half davies became wru chairman on tuesday 21 october , succeeding deposed david pickering following governing body elections . he is now serving a notice period to leave his role as newport gwent dragons chief executive after being voted on to the wru board in september . davies was among the leading figures among dragons , ospreys , scarlets and cardiff blues officials who were embroiled in a protracted dispute with the wru that ended in a # 60m deal in august this year . in the wake of that deal being done , davies said the # 3 . 3 m should be spent on ensuring current wales - based stars remain there . in recent weeks , racing metro flanker dan lydiate was linked with returning to wales . likewise the paris club ' s scrum - half mike phillips and centre jamie roberts were also touted for possible returns . wales coach warren gatland has said : ` ` we have n ' t instigated contact with the players . ` ` but we are aware that one or two of them are keen to return to wales sooner rather than later . ' ' speaking to scrum v on bbc radio wales , davies re - iterated his stance , saying keeping players such as scarlets full - back liam williams and ospreys flanker justin tipuric in wales should take precedence . ` ` it ' s obviously a limited amount of money - lsb - available - rsb - . the union are contributing 60 % of that contract and the regions are putting # 1 . 3 m in . ` ` so it ' s a total pot of just over # 3m and if you look at the sorts of salaries that the . . . guys . . . have been tempted to go overseas for - lsb - are - rsb - significant amounts of money . ` ` so if we were to bring the players back , we ' d probably get five or six players . `
new welsh rugby union chairman gareth davies believes a joint # 3 . 3 m wru - regions fund should be used to retain home - based talent such as liam williams , not bring back exiled stars .
[CLS] amod [SEP] new [SEP] gareth [SEP]
0 5
gold: 0
pred: 0
0.7826827 0.21731725
[CLS] amod [SEP] welsh [SEP] gareth [SEP]
1 5
gold: 0
pred: 0
0.74857944 0.2514206
[CLS] amod [SEP] rugby [SEP] gareth [SEP]
2 5
gold: 0
pred: 0
0.58793193 0.4120681
[CLS] compound [SEP] union [SEP] gareth [SEP]
3 5
gold: 0
pred: 0
0.696159 0.303841
[CLS] compound [SEP] chairman [SEP] gareth [SEP]
4 5
gold: 0
pred: 0
0.6965902 0.30340976
[CLS] nsubj [SEP] gareth [SEP] davies [SEP]
5 6
gold: 0
pred: 0
0.90575594 0.094244026
[CLS] ccomp [SEP] believes [SEP] davies [SEP]
7 6
gold: 0
pred: 1
0.3829971 0.61700296
[CLS] amod [SEP] joint [SEP] fund [SEP]
9 18
gold: 0
pred: 1
0.12907948 0.87092054
[CLS] compound [SEP] # [SEP] fund [SEP]
10 18
gold: 0
pred: 1
0.07523679 0.92476314
[CLS] nummod [SEP] 3. 3 [SEP] fund [SEP]
13 18
gold: 0
pred: 1
0.07547788 0.9245221
[CLS] compound [SEP] m [SEP] fund [SEP]
14 18
gold: 0
pred: 1
0.0737554 0.92624456
[CLS] compound [SEP] wru - regions [SEP] fund [SEP]
17 18
gold: 0
pred: 1
0.06213749 0.9378625
[CLS] nsubjpass [SEP] fund [SEP] used [SEP]
18 21
gold: 0
pred: 1
0.036747348 0.96325266
[CLS] nsubj : xsubj [SEP] fund [SEP] retain [SEP]
18 23
gold: 0
pred: 1
0.038346358 0.9616537
[CLS] ccomp [SEP] used [SEP] believes [SEP]
21 7
gold: 0
pred: 1
0.105117984 0.894882
[CLS] xcomp [SEP] retain [SEP] used [SEP]
23 21
gold: 0
pred: 1
0.057261348 0.94273865
[CLS] amod [SEP] home - based [SEP] talent [SEP]
26 27
gold: 0
pred: 1
0.19978425 0.8002157
[CLS] dobj [SEP] talent [SEP] retain [SEP]
27 23
gold: 0
pred: 1
0.12622716 0.87377286
[CLS] mwe [SEP] as [SEP] such [SEP]
29 28
gold: 0
pred: 1
0.17707714 0.8229228
[CLS] compound [SEP] liam [SEP] williams [SEP]
30 31
gold: 0
pred: 1
0.21542485 0.78457516
sent gold: -1
sent_pred: 0
The parsing is definitely different, I see that the first arc on my end is : '[CLS] amod [SEP] new [SEP] gareth [SEP]' whereas it is '[CLS] compound [SEP] new [SEP] welsh [SEP]' at your end. My expectation is that this would change the predictions significantly.
Another thing that may be diff (I don't see corresponding code for that above), is how the dependency level labels are converted to token level. This is something I will share in the code release.
Thanks!
Tanya
Hi,
after digging around, I realized it was the incorrect CoreNLP version. Now I am getting the same output. Thanks!
Hi Tanya,
I was also trying to reproduce the generation data on XSum, i.e. running the best_ckpt model on XSum and get the corresponding labels, but I am getting mismatch in the number of labels deemed unfactual. Any pointers on how to generate such datasets would be helpful!
I am running on a modified script based on
evaluate_generated_outputs.py
, which I have attached below. The only change is that I am using Stanza's CoreNLP with Parser 3.6.0 instead ofpycorenlp
packet, as I am getting errors with the CoreNLP part. I have checked and am using the same parser version. I have marked my changes with comment in the form of# CHANGES!
For the model, I am using
DAE_xsum_human_best_ckpt
, and running the evaluation with the parameter:python eval_gen_out.py --model_type electra_dae --model_dir DAE_xsum_human_best_ckpt --input_file test.txt
the test file I have tried is both the first data line in the train.tsv as well as the untokenized version from the original XSum dataset:
Original text:
Output:
Tokenized text:
Output:
As you can tell, both have only one dep considered as unfactual, and I dont think this matches with the output_ids
3 2 5 4 1 0 6
The modified script:
Best, David