Feat/test multi arch - Githubissues

tagua-vm / parser

Safe, fast and memory efficient PHP parser (lexical and syntactic analysers, and the Abstract Syntax Tree)

http://tagua.io/

119 stars 15 forks source link

Feat/test multi arch #106

Closed Pierozi closed 7 years ago

Pierozi commented 7 years ago

Following PR #97 of @mathroc

The Dockerfile has been fixed in order to run with success all the suite test. Makefile was also created to make it easier to run testing with different tools like cross with architecture emulation in QEMU inside docker.

coveralls commented 7 years ago

Coverage remained the same at 93.502% when pulling 3a83bacfb2c9ba8ea3702a6ca59fdb355d7ec161 on Pierozi:feat/test-multi-arch into e7aa96322c4abe0a758286a5033dcec90cf28a21 on tagua-vm:master.

Hywan commented 7 years ago

Why adding cross right?

Pierozi commented 7 years ago

Cross is only in Makefile target, your not force to install it, but if you do not want theses script in the Project I understand, in this case maybe cloud just specify in Documentation / Readme under Dev Tools section.

Cross was pretty easy for build and test multi environment quickly. Makefile was only a lazy way to remember the command to launch.

Hywan commented 7 years ago

This PR introduces 2 things: Docker stuff, and a Makefile. As far as I understand, they are not relateed. Please, choose one :-).

Pierozi commented 7 years ago

My bad, Makefile removed :)

docker-compose up test Will auto build and execute test inside a container based on Dockerfile
docker-compose up -d cli Will run container and keep it alive to be able to use interactive mode

coveralls commented 7 years ago

Coverage remained the same at 93.433% when pulling 7dae9aee5a8115d9f51bbef0e92a1f76dac66dad on Pierozi:feat/test-multi-arch into 7b21875dc5da4b2a05d988eb45f56933b92ed423 on tagua-vm:master.

coveralls commented 7 years ago

Coverage remained the same at 93.433% when pulling 7dae9aee5a8115d9f51bbef0e92a1f76dac66dad on Pierozi:feat/test-multi-arch into 7b21875dc5da4b2a05d988eb45f56933b92ed423 on tagua-vm:master.

Hywan commented 7 years ago

Sorry to insist, but:

docker-compose up -d cli

What's the goal of this for this project?

Pierozi commented 7 years ago

as said

Will run container and keep it alive to be able to use interactive mode

Useful for debug mode when you want execute interactive command.

Hywan commented 7 years ago

What interactive command do we have on this project :-/? Again, I am not convinced at all by the needs of Docker for this library :-(.

Pierozi commented 7 years ago

In this case, drop it! :) I'm aware a Docker is trivial for Tagua, the developer already have rust installed (obviously) It's just a virtual chroot to run test on proper versions and have a clean slate each time it's running.

Hywan commented 7 years ago

@Pierozi Can you update the README.md please :-)?