search

tagyoureit / nodejs-Pentair

An application to read/write to Pentair pool controllers.
14 stars 6 forks source link

Bootstrap schedules wrap #26

Closed tagyoureit closed 7 years ago

tagyoureit commented 7 years ago

Minor adjustment needed as the schedules are wrapping.

screen shot 2016-10-22 at 11 46 22 pm

arrmo commented 7 years ago

Agreed! Saw that as well in your pic, thanks for capturing this one. There is a (sort of?) way to customize it right now, but let's take care of bigger items first, then I'll explain how to use the one json file.

arrmo commented 7 years ago

Does adjusting the min width in style.css address / correct this? Still trying to find a way to stop wrap, but this may fix it?

tagyoureit commented 7 years ago

Yes. Changing to 600 (from 570px) for me works great. Maybe on shorter widths the days could appear as a second line under each schedule? This would save space, as well. Better for small screens like phones.

arrmo commented 7 years ago

I like that! Do we do that by default? It may be cleaner. I'd still like this to auto-adjust (the panel width), but so far it's past my brain capacity ... :(.

arrmo commented 7 years ago

Quick hack ... like this? Need to clean up the underline of course. image

arrmo commented 7 years ago

OK, border removed, padding ("combined" rows) minimized, image

tagyoureit commented 7 years ago

Love it! Looks great. :-)

arrmo commented 7 years ago

Will push this sometime this weekend. Thanks!

arrmo commented 7 years ago

Closed with latest PR#34 ... close this?

tagyoureit commented 7 years ago

Yup, agreed. I'll close it.