search

tagyoureit / nodejs-Pentair

An application to read/write to Pentair pool controllers.
14 stars 6 forks source link

Run mode on pool status #52

Closed tagyoureit closed 7 years ago

tagyoureit commented 7 years ago

Is it necessary? Research why it's there.

arrmo commented 7 years ago

Or ... I could just add client logic = show as Running, if Pool or Spa are on?

tagyoureit commented 7 years ago

I had this in the 1.0 code base: https://github.com/tagyoureit/nodejs-Pentair/blob/master/index.js#L1030 status.runmode = strRunMode[data[controllerStatusPacketFields.UOM] & 129]; // more here?

I turned on my pool, but didn't see anything correlating to 129. Let's remove it for now. It would be redundant to having the pool/spa indicators on.

If we wanted to make this a "summary" tab of everything that's on, then it might make more sense. But I think it's ok for now just to remove it.

arrmo commented 7 years ago

NP, will remove it! A bit behind on work at home right now, but will get to it this weekend.

Thanks!

arrmo commented 7 years ago

Removed - PR #53 created.