search

tagyoureit / nodejs-poolController

An application to control pool equipment from various manufacturers.
GNU Affero General Public License v3.0
326 stars 96 forks source link

[Feature Request] Resume schedule after panel mode set back to Aut #1032

Open dkossman opened 1 month ago

dkossman commented 1 month ago

nodejs-poolController Version/commit

8.0.4 / 838dfce

nodejs-poolController-dashPanel Version/commit

8.0.0 / ee5b7b9

relayEquipmentManager Version/commit

e8a4ff1a65552bb2c6feee6d173a393d10b53 refs/heads/master

Node Version

v18.19.0

Platform

Linux njspcpi 6.6.31+rpt-rpi-v8 #1 SMP PREEMPT Debian 1:6.6.31-1+rpt1 (2024-05-29) aarch64 GNU/Linux

RS485 Adapter

JBTek i think

Are you using Docker?

OCP

None / using Nixie

Pump(s)

Intelliflow VS

Chlorinator(s)

None

What steps will reproduce the bug?

  1. set up a schedule e.g. 11am - 3pm with pump at 1000 rpm
  2. sometime between the schedule start and end times, set the system into service mode
  3. within the schedule, set the system back into auto mode

What happens?

schedule does not resume

What should have happened?

currently active schedule should resume - in this case, pump should run at 1000 rpm

Additional information

Per some related discussions, i've implemented a button on my pool panel to toggle NJSPC service mode. This works, but I've noticed that if the timing is such that the system should continue running a schedule when it is set back to Auto mode, it does not do so.

e.g. i have a schedule that runs the pump at 1000rpm from 11am to 3pm. If i turn on service mode at 11:30, then set it back to auto mode at 11:45, i'd expect the schedule to resume and the pump to go back on at 1000rpm. it does not. Dashpanel does not show the schedule as active and the pump stays at 0.

I see the same behavior as with my button when toggling service mode from Dashpanel, either when manually setting it back to auto mode, or after the timeout for service mode expires.

Am i missing something, is this by design, is there some additional configuration needed to get the desired resume schedule behavior, or is this a bug?

My use case (which i assume is common) is to allow my pool service technician to (just use the button to) put the system into service mode so he can control the pump, then put it back into auto mode when he is done, and have njspc continue to operate things as scheduled without me having to intervene using Dashpanel or anything else...

Edit: I was just pointed to the discussion about the rationale for not resuming schedules coming out of service mode. It would be great if there was a configuration option (which defaults to “off “) to govern whether schedules are resumed when returning to auto mode. in my case the button does not set up a service mode timeout, it just toggles service mode. So the concern about unexpected resumption of equipment would not apply.

I’m also thinking to use a toggle switch instead of a button so that even if the system restarts it comes back up in service mode if the switch is on.

dkossman commented 1 month ago

Changed to a feature request since I was made aware that the current behavior is by design