Create API to allow Pump RPM change

johnny2678 commented 5 years ago

*Enhancement Request, not a bug

Currently, to change the Pump RPMs through poolController, you have to define circuits in your automation and then use poolController to turn on/off those circuits.

Would be awesome if you could set the circuit RPMs using poolController.

I only need API, but someday doing this through the UI would be cool too.

What version of the code are you using?

5.3

Your pool equipment

Pentair EasyTouch / Pentair VS Pump / Pentair SWG

bsileo commented 5 years ago

Would these APIs provide the needed functionality @johnny2678 @MaxVonEvil ?

/pumpCommand/run/pump/{pump}/rpm/{rpm} /pumpCommand/run/pump/{pump}/gpm/{gpm} /pumpCommand/run/pump/{pump}/rpm/{rpm}/duration/{duration}

But maybe these will not work in all cases - I see the note "(Not Intellitouch)" with these APIs....

bsileo commented 5 years ago

One question on this @tagyoureit - What is the possible range for Pump RPMs? I assume this might depend on the equipment and I am not sure there is a way to get it from the config. This is a challenge for a slider control in ST since the UI is static there - basically I have to predefine the "range" for the slider upfront.

tagyoureit commented 5 years ago

Typically, 450-3450RPM is the range for the pumps. It's usually in the manuals somewhere but that's the range I check for in the app.

Those /pumpCommand/ API's are for the standalone pump. The Intellitouch RPM's need to be set through the Configuration settings so they do need to be added.

bsileo commented 5 years ago

Ok I have put together the basic structure for this...once APIs are in place it will be easy to hook them in. Side benefit...adding the new Pentair Pump Controller child device now allows us to have a Power meter device in Smart Things so you get access to the watts reported by the pump!

MaxVonEvil commented 5 years ago

Hi all, thanks for responding to this idea.

@bsileo - I was playing around with @tagyoureit 's API's, manually firing commands off in a browser. They ought to suffice for this proposed change, However, there's a few things worth highlighting, if one (like me) does not have any pentair control equipment except the pump itself:

1) All pumps aren't created equally. For example when I moved in, the pool had an old, noisy and powerhungry 1kW single-speed pump. It had no brains, i.e. no RS485 port, hence only way to control it, would be a simple on/off switch like the Aeotec Heavy Duty Switch (which btw has a power-meter and kWh counter!) Perhaps worth it to support such a switch as a pump? There's still many of them old pumps around.

2) As I learned, even VariSpeed pumps are different. I promptly replaced mentioned singlespeed clunker with a Pentair Intelliflo VS model 011018. Contrary to other pumps (VariFlo?) it seems only to deal in RPM's. It has no concept of GPM's.

3) About the min/max pump RPM speeds you asked about, yes the defaults are 450-3450 RPM as Tag pointed out. However they are (in my case) configurable on the pump's own panel. Yet not owning any, I have no idea if Pentair's control hardware is able to override those min/max values.

Unless Brad beats me to the punch :) (likely, as my coding time is minimal these next few weeks) my own nefarious plans is to repurpose some DHT code used to control the API's on my security cameras, mash it up with some standard dimmer code, creating a stand-alone DHT for the forementioned dimmer-type controlling the pump, by talking to Tag's pool-controller API's.
The UX would re-use the standard dimmer's on/off and slider controls. I would however create the min/max rpm's as configurable options with defaults as above, setting the custom range for the slider. One could later add more bells, converting RPM's to percentages, or to opt to use GPM's instead of RPM's.

@bsileo - was the above something along the lines of what you had in mind for the DTH?

Thanks, Max

bsileo commented 5 years ago

I had some time this morning so there is a first pass at this device type in my repo here.

This is built to run integrated with the overall PoolController family of devices (e.g. it is setup to be a child of the main Pentair Pool Controller device) so this is not quite the same as what you described.

So far, I have it setup with a slider for RPMs, and on/off toggle, and a report of the wattage. Other data values form the pump are available just not on the UI at this point.

There are still a few gaps - most notably, the on/off is hardcoded to Circuit 6 so will only work for a single Pump on the Pool side right now. @tagyoureit is going to add an API in the future for this. Also, the API call to set pump speed is disabled right now (though it is in the code) since it does not actually work for non standalone use cases.

MaxVonEvil commented 5 years ago

Great, I'll see if I can get time to try it this weekend. Two quick ones, if you don't mind:

Can the pool-controller device actually be installed without child apps for stuff one doesn't have, such as chlorinators, lights, etc? Instructions says to install them all. Just wanted to minimize the footprint if possible. Canthe childDeviceTitle() references just be knocked out?
This business of circuit 6... how does that translate to the lone VS pump I have here? I know I can change it's address on the RS485 bus, yet something tells me said circuit is something else - if memory serves me right it's something defined in the Easytouch systems, right? I guess what I'm asking is how, if at all does this affect my setup?

Thanks, Max

bsileo commented 5 years ago

Can the pool-controller device actually be installed without child apps for stuff one doesn't have, such as chlorinators, lights, etc? Instructions says to install them all. Just wanted to minimize the footprint if possible. Canthe childDeviceTitle() references just be knocked out?

It will auto create child apps for everything it thinks exists on the system. Some stuff it can not tell and it just creates it. After that, you can go in and delete any child devices you do not want to keep. This is done via the Things via in the Smart App or the devices list in the IDE.

This business of circuit 6... how does that translate to the lone VS pump I have here? I know I can change it's address on the RS485 bus, yet something tells me said circuit is something else - if memory serves me right it's something defined in the Easytouch systems, right? I guess what I'm asking is how, if at all does this affect my setup?

I am not sure about this but I suspect it will not match up for you as Circuit 6 is specific to Easy/Intellitouch.

MaxVonEvil commented 5 years ago

Okay, looks like a separate DHT may be needed to fill the gap between those installations which have all the Pentair gear already and those of us who are trying to avoid buying it to begin with ;)

I'm going to have a stab at this when I get some time, but if someone makes something in the interim, I'm all ears.

rsissons commented 5 years ago

@bsileo and @tagyoureit - I am not getting any values for my pump (VS)

Parameter Pump 1 Watts wattsnotset RPM rpmnotset Error errnotset Drive State drivestatenotset Run Mode runnotset Am I missing something?

Thx

MaxVonEvil commented 5 years ago

Initial thoughts: Are you getting any console messages of significance on your RaspberryPi?

On Thu, May 9, 2019 at 10:36 AM rsissons notifications@github.com wrote:

@bsileo https://github.com/bsileo and @tagyoureit https://github.com/tagyoureit - I am not getting any values for my pump (VS)

Parameter Pump 1 Watts wattsnotset RPM rpmnotset Error errnotset Drive State drivestatenotset Run Mode runnotset Am I missing something?

Thx

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tagyoureit/nodejs-poolController/issues/123#issuecomment-490997255, or mute the thread https://github.com/notifications/unsubscribe-auth/AEXRQVFONZ3ADXXRZVCJO7DPUROKNANCNFSM4HIGYI5A .

--

With best regards, Max Ranzau / +1 610 462 2200

tagyoureit commented 5 years ago

What do you get if you navigate to http://your_pool_server:3000/all? You can also attach the replay logs here and I could have a quick look.

rsissons commented 5 years ago

What do you get if you navigate to http://your_pool_server:3000/all? You can also attach the replay logs here and I could have a quick look.

Here's what I get with /all

Here's a link to the replay files. https://drive.google.com/file/d/1-l7fXMXrc3M9a-MFW40VN8p3yttnnRY1/view?usp=sharing

rsissons commented 5 years ago

I am not sure if this has anything to do with it or not?

ERROR Aborting controller packet Get Pump Config (Extended). Tried 10 times to write 255,0,255,165,1,16,33,219,1,1,1,180

tagyoureit commented 4 years ago

v6 is ready for testing. Chlorinator directions Pump directions

There is native support for controlling pump RPM. API's are in place and will be documented shortly.

tagyoureit / nodejs-poolController

Create API to allow Pump RPM change #123