[BUG] Heliotrope and schedule flexibility logic

[CodeSlinger69]

nodejs-poolController Version/commit

head

nodejs-poolController-dashPanel Version/commit

No response

relayEquipmentManager Version/commit

No response

Node Version

No response

Platform

No response

RS485 Adapter

No response

Are you using Docker?

• [ ] Yes.

OCP

No response

Pump(s)

No response

Chlorinator(s)

No response

What steps will reproduce the bug?

I wanted to leverage Nixie to automatically cool my pool at night using my solar system. Nixie checks to see "isNight" as a condition for doing so, but the logic in this method was incorrect.

Additionally, I wanted schedules that cross the midnight boundary, for example sunset to sunrise, or just 22:00 - 06:00. The logic to determine if a schedule should be "on" does not handle this situation.

I've corrected the logic, it works in my testing so far, and I created a number of pull requests (1, 2, 3) for inclusion in the official code base if wanted. I'll be honest, I am not a git expert, so forgive me if I messed up the branches, pulls, pushes, commits, and so on.

I've also created a few other pull requests (1, 2) for other bugs I discovered along the way.

I'm pleased that Nixie is working the way I want now, and please feel free to use my code if its helpful.

What happens?

See above.

What should have happened?

See above.

Additional information

No response

[rstrouse]

I’ll check them out tomorrow and integrate them.

[CodeSlinger69]

Closing this due to learning that njsPC had a design decision to NOT allow schedules to cross the midnight boundary.