search

tagyoureit / nodejs-poolController

An application to control pool equipment from various manufacturers.
GNU Affero General Public License v3.0
327 stars 97 forks source link

[BUG] Egg Timers & Schedules Not Showing #835

Closed matthewusf closed 1 year ago

matthewusf commented 1 year ago

nodejs-poolController Version/commit

8.0.1

nodejs-poolController-dashPanel Version/commit

8.0.0

relayEquipmentManager Version/commit

No response

Node Version

18.17.0

Platform

No response

RS485 Adapter

No response

Are you using Docker?

OCP

No response

Pump(s)

No response

Chlorinator(s)

No response

What steps will reproduce the bug?

replay (4).zip

I updated to the latest version (sunset/sunrise offsets as a reference point is a really neat idea), but I no longer consistently get the length of time the circuit has left - could be unrelated but I noticed it right after. It seems arbitrary which ones work and don't (not always the same ones either). I pulled the actual circuit info via the /state/circuitGroups API and sure enough, for the ones that don't show it, there is no endTime but the ones that do absolutely have it. Also, the ones that don't show an endTime still do seem to stop when they're supposed to via the egg timer so the data is somewhere but njsPC seems to not be receiving it?

What happens?

No time to stop circuit reported

What should have happened?

Reporting time to stop circuit

Additional information

No response

rstrouse commented 1 year ago

Please pull njsPC again. You may have gotten the pull prior to the schedule updates for IntelliCenter.

matthewusf commented 1 year ago

Thanks for your continued help - I did go ahead and pull a fresh latest version yesterday without any of my CSS modifications, on the off chance an update had made my adjustments inoperable. However, the behavior persists and is inconsistent - this morning, another circuit correctly showed the time remaining but another did not. If I pull from state/circuitGroups, I do get the same result (the ones on njsPC-dashPanel that show do have endTime and those that don't, do not).

What can I do to help diagnose? Really appreciate it!

rstrouse commented 1 year ago

I went through the code and found a couple of places where the end time was not getting updated. Pull njsPC. Also, you should look into using the Chem Doser component as this will allow you to set dosage times and manage your tank volumes.

matthewusf commented 1 year ago

Completely fixed it - I'm shocked! You've created such an incredible platform, can't thank you enough. Chem doser is on my "to do" list for sure - just have to get brave and start trying to figure it out

rstrouse commented 1 year ago

The Chem Doser will give you a very simple to use interface that can be adjusted on the fly.

image

matthewusf commented 1 year ago

For some reason, I have lost the End Timer again. I have updated to the latest version - any suggestions for me to look into?

matthewusf commented 1 year ago

EDIT: Resolved the next day (restart?) and has worked great ever since, thanks so much!