search

tahnok / colmi_r02_client

A python client + documentation for the Colmi R02 smart ring
MIT License
299 stars 15 forks source link

Python 3.9 unsupported #8

Open ghayne opened 2 weeks ago

ghayne commented 2 weeks ago

I'm getting the following error:

ERROR: Package 'colmi-r02-client' requires a different Python: 3.9.2 not in '<3.13,>=3.11'

tahnok commented 2 weeks ago

At the moment I've only tested with python 3.11, it looks like you have python 3.9

On Mon, Oct 21, 2024, 13:48 Garry Hayne @.***> wrote:

I'm getting the following error:

ERROR: Package 'colmi-r02-client' requires a different Python: 3.9.2 not in '<3.13,>=3.11'

— Reply to this email directly, view it on GitHub https://github.com/tahnok/colmi_r02_client/issues/8, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACYSEPNJ2C4TE6EYX5QKG3Z4U47XAVCNFSM6AAAAABQKWQIKGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGYYDGMRWGMZDKOA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

ghayne commented 1 week ago

Any way around the error?

benhaney commented 1 week ago

Similar situation here, but with Python 3.13.0 (which is of course not less than 3.13)

Maybe only allowing installation on exactly two minor python versions is a bit too restrictive? Especially if pipx is the recommended installation method.

tahnok commented 1 week ago

Fair, I just used whatever poetry defaulted to but an upper bound seems dumb

On Tue, Oct 22, 2024, 20:26 Ben Haney @.***> wrote:

Similar situation here, but with Python 3.13.0 (which is of course not less than 3.13)

Maybe only allowing installation on exactly two minor python versions is a bit too restrictive? Especially if pipx is the recommended installation method.

— Reply to this email directly, view it on GitHub https://github.com/tahnok/colmi_r02_client/issues/8#issuecomment-2430556169, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACYSEND45DVZ2LL6K3QYS3Z43UM5AVCNFSM6AAAAABQKWQIKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZQGU2TMMJWHE . You are receiving this because you commented.Message ID: @.***>

tahnok commented 1 week ago

Ok, I removed the upper bound if you want to try again

tahnok commented 1 week ago

I'm open to lowering the python version but I'm gonna guess I used something that has been out since 3.9 was released and I'd have to consider if it's worth supporting. If someone does look, feel free to share