search

tahoe-lafs / magic-folder

Tahoe-LAFS-based file synchronization
Other
25 stars 7 forks source link

Conflicted files and downloads #731

Closed meejah closed 1 year ago

meejah commented 1 year ago

According to https://whetstone.private.storage/privatestorage/privatestoragedesktop/-/issues/791#note_30691 it appears that conflicted files are queued for download, but never complete.

They should either complete successfully (i.e. because we concluded "yes, still conflicted") or just not start in the first place (i.e. because we know it's already conflicted, so why download a Snapshot at all).

Beware that care may be required here: a file may become conflicted with Participant A and then some time later also become conflicted with Participant B -- we still want to detect that second case (while still under conflict to A). That is, we shouldn't download any additional updates for "A" after detecting the conflict, but we probably do want to download updates from other participants (so we can record more conflicting participants, if they do indeed conflict).

meejah commented 1 year ago

This should be fixed now, will close when @crwood confirms in a "real" Gridsync situation.