search

tahoe-lafs / pycryptopp

Python bindings to the Crypto++ library
https://tahoe-lafs.org/trac/pycryptopp
Other
49 stars 32 forks source link

Simplify and otherwise improve the version number #38

Closed exarkun closed 7 years ago

exarkun commented 7 years ago

Fixes https://tahoe-lafs.org/trac/pycryptopp/ticket/107 Fixes https://tahoe-lafs.org/trac/pycryptopp/ticket/99

zooko commented 7 years ago

Awww.

Although I have to admit SHA1 sucks.

On Feb 24, 2017 09:59, "Jean-Paul Calderone" notifications@github.com wrote:

Fixes https://tahoe-lafs.org/trac/pycryptopp/ticket/107 Fixes https://tahoe-lafs.org/trac/pycryptopp/ticket/99

You can view, comment on, or merge this pull request online at:

https://github.com/tahoe-lafs/pycryptopp/pull/38 Commit Summary

  • Version a dirty working copy after whatever the clean version would be.
  • Don't put the post version in the middle
  • Don't put the git sha1 in the version number.

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tahoe-lafs/pycryptopp/pull/38, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcjvCb1g8hbvDA7MCNp838-qHCZBaLJks5rfwyGgaJpZM4MLb9Y .

exarkun commented 7 years ago

Although I have to admit SHA1 sucks.

Haha. Yes I'll totally claim that's the reason to do this. :)

warner commented 7 years ago

Looks good, merging. In today's nuts+bolts we decided we should probably move to straight Versioneer (and also update it to a recent copy), but we need to understand the implications for extraversion.h before making that change.