tahowallet / dapp

Subscape dApp
https://app.taho.xyz/
MIT License
3 stars 4 forks source link

Fix token input for typing balance value manually #862

Closed jagodarybacka closed 6 months ago

jagodarybacka commented 7 months ago

Resolves https://github.com/tahowallet/dapp/issues/764

What

When user was typing the balance amount manually then input was not updating values correctly. We moved to useCallback instead of useEffect and fixed the condition for updating parent component with new values.

The issue was caused mostly by incorrect condition but I wanted to get rid of useEffect as the dependencies array was intentionally incomplete and it seems like it wasn't the most correct hook anyway.

Testing

General regression testing is needed here (@michalinacienciala). Let's not merge unless it will be tested for regressions.

image

netlify[bot] commented 7 months ago

Deploy Preview for taho-development ready!

Name Link
Latest commit 97f1a546be15068fb2dc6e036d1aa02cba37b3d5
Latest deploy log https://app.netlify.com/sites/taho-development/deploys/65731e8b98a3b600081616fe
Deploy Preview https://deploy-preview-862--taho-development.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.