Open brandoncurtis opened 2 years ago
these transactions that fail to broadcast are still, apparently, increasing the nonce that's being used locally:
ChainService.populateEVMTransactionNonce
Got chain nonce,8,existing nonce,18,using,19
at ChainService.populateEVMTransactionNonce (chrome-extension://eajafomhmkipbjmfmhebemolkcicgfmd/background.js:59109:22), at async SigningService.signTransaction (chrome-extension://eajafomhmkipbjmfmhebemolkcicgfmd/background.js:71260:40), at async chrome-extension://eajafomhmkipbjmfmhebemolkcicgfmd/background.js:73745:47, at async Promise.all (index 0), at async Emittery.emit (chrome-extension://eajafomhmkipbjmfmhebemolkcicgfmd/background.js:6698:11), at async chrome-extension://eajafomhmkipbjmfmhebemolkcicgfmd/background.js:72486:9, at async chrome-extension://eajafomhmkipbjmfmhebemolkcicgfmd/background.js:63016:20
retrying the transaction:
ChainService.populateEVMTransactionNonce
Got chain nonce,8,existing nonce,19,using,20
at ChainService.populateEVMTransactionNonce (chrome-extension://eajafomhmkipbjmfmhebemolkcicgfmd/background.js:59109:22), at async SigningService.signTransaction (chrome-extension://eajafomhmkipbjmfmhebemolkcicgfmd/background.js:71260:40), at async chrome-extension://eajafomhmkipbjmfmhebemolkcicgfmd/background.js:73745:47, at async Promise.all (index 0), at async Emittery.emit (chrome-extension://eajafomhmkipbjmfmhebemolkcicgfmd/background.js:6698:11), at async chrome-extension://eajafomhmkipbjmfmhebemolkcicgfmd/background.js:72486:9, at async chrome-extension://eajafomhmkipbjmfmhebemolkcicgfmd/background.js:63016:20
Thanks for this ser, we're digging in
Ok so we need a nonce release in the catch at https://github.com/tallycash/extension/blob/fddd29d7687bcbf726ae82472ee59c09588ec76b/background/services/chain/index.ts#L1001 to mitigate the nonce issue (not, notably, the fee issue that is triggering it). The subtlety there is going to be whether all caught errors should release the nonce, or only a subset. My best guess right now is that releasing the nonce for all of them would not be crazy.
This is also raising priority for custom nonces IMO #2057 → right now the only recourse @brandoncurtis has is to reinstall the wallet or wait for an update, which isn't great.
Discord Discussion Link
No response
What browsers are you seeing the problem on?
Chrome
What were you trying to do?
Deploy a new Gnosis Safe using the gnosis-safe.io UI and Ledger Nano X.
What did not work?
The Safe creation transaction repeatedly fails to broadcast.
Fails whether or not I change the fee rate from the default.
Based on the displayed fee on the Ledger and the errors in the logs, I believe this is a problem in fee calculation resulting in an insufficient fee.
Version
v0.15.0
Relevant log output