tahowallet / extension

Taho, the community owned and operated Web3 wallet.
https://taho.xyz
GNU General Public License v3.0
3.11k stars 394 forks source link

Notifications service #257

Open mhluongo opened 3 years ago

mhluongo commented 3 years ago

The notifications service should do two things

The hardest part of writing this is figuring out what an app-level notification is, and deciding what sorts of things should be a browser-level notification. Currently, there's some consensus that the latter includes changes to any transaction that the wallet has sent (eg a failure, dropping from mempool, or a confirmation).

@VladUXUI if you can attach any / all notification screens and thinking on the UX here it'll make this one easier to figure out.

Refs #106.

VladUXUI commented 3 years ago

image

VladUXUI commented 3 years ago

I've used mostly dummy content for the notification itself. What i think should be app notifications are notifications that are: 1 - Not triggered by this user (receive, dao proposals, liquidations...) 2 - Triggered by user, but have an un-expected outcome. (Tx: failure, dropping from mempool...) I don't see tx confirmation in-app notification as being particularly useful.

Would it be safe/easy to show all notification as browser notifications? but keep the ones we think users will care about in our notification center?