⚡️Wallet Connect

[greg-nagy]

Work Breakdown

Product work

• [x] #2685
• [x] #2686
• [x] #2771

Design work

• [x] #2714
• [x] #2895
• [x] 🛑 #2684
• [x] 🛑 #2753

Dev work

• [x] #2683
• [x] #2688
• [x] #2687
• [x] #2751
• [x] #2772
• [x] #2752
• [x] 🛑 #2689
• [x] 🛑 #2690
• [x] 🛑 #2692

Backlog

-❓Implement v1 support

• v1 should be deprecated in March 2023, but most of dApps are still on v1. Let's see where the ecosystem is at when we get to this point and make a decision then.

[greg-nagy]

kick-off call notes:

• we went through the overall dataflow
  • we will need an intermediary website to accept the connection - we can either close after connection or use this similar to tokenary - this requires product decision and/or design
  • we can use the custom RPC communication method from the website similar to tally_setClaimReferrer method
• we discussed some extra options on how to make the UX better and what we should and shouldn't do — inject button etc
  • We could open the dApp connection modal as soon as the QR code is shown on the page
• we will go with v2 support, since v1 will be deprectaed in 2023 march
• we had some discussion about the overall architecture and dev practises. (But these are not important for now.)
  • ProviderBridgeService, InternalEthereumService, injected script \<> content script \<> provicer bridge service \<> internal ethereum service
  • trunk based development, feature flags, short lived feature branches, analytics init PR as a blueprint for service creation
• There is a possble issue about how do we listen to async events / how do we close the data loop / how does the wallet gets notified about the fact that something needs to be signed
  • this might be extra problematic in manifest v3
• we agreed on the simplest POC possible as a next step
  • trying to create a similar solution to the test web wallet example without affecting the rest of the codebase
  • this POC will be dirty, hardcoded — just like a true POC should be

[VladUXUI]

All the tickets that are with blocker icon 🛑 are tickets we don't need completed to consider V1 ready to ship. Uncertain if we want to remove from the list so we have a more accurate view of the milestone, or just separate them into Inject / Registry. Inject being the version that we are doing first

[puppycodes]

Acceptance Criteria:

• [ ] Users are able to sign transactions and connect to dApps via the wallet connect integration