search

tahowallet / extension

Taho, the community owned and operated Web3 wallet.
https://taho.xyz
GNU General Public License v3.0
3.12k stars 394 forks source link

Connecting to zigzag exchange gives unexpected error #2818

Open Naxsun opened 1 year ago

Naxsun commented 1 year ago

Discord Discussion Link

n/a

What browsers are you seeing the problem on?

Chrome

What were you trying to do?

Connect to ZigZag exchange

What did not work?

Extension pops up with an 'unexpected error' message

https://user-images.githubusercontent.com/71384922/209774768-0f226423-ce72-4cfb-b3a0-ea16db3cd12c.mov

Version

v0.18.6

Relevant log output

No response

Shadowfiend commented 1 year ago

This is because we're receiving an unexpected first parameter in the eth_requestAccounts call, which looks like { "eth_accounts": {} }. In fact, we should be ignoring any parameters to that call, meaning the following line should replace rather than push:

https://github.com/tahowallet/extension/blob/9a51b5a6c91255cef7dcbc7bdda98fdadc597c1b/provider-bridge/index.ts#L33

kkosiorowska commented 1 year ago

The issue has not been fully resolved by https://github.com/tahowallet/extension/pull/3546. The error has disappeared, but we still cannot connect.