tahowallet / extension

Taho, the community owned and operated Web3 wallet.
https://taho.xyz
GNU General Public License v3.0
3.11k stars 394 forks source link

Issues with dropped transactions on fresh wallets #3574

Open Shadowfiend opened 1 year ago

Shadowfiend commented 1 year ago

Discord Discussion Link

https://discord.com/channels/808358975287722045/888500174685614090/1133713825712046150

What browsers are you seeing the problem on?

Chrome

What were you trying to do?

perform a transaction on the zora bridge (https://bridge.zora.energy/)

what triggered the issue (Send): send eth on eth mainnet to eth on zora minnet

What did not work?

there was a problem sending the transaction with taho wallet

The window pops up, I click confirm and nothing happens in the wallet there is no transaction and in etherscan there is no transaction either.

Version

v0.42.0

Relevant log output

Logs from one report

Shadowfiend commented 1 year ago

The particular pattern I noticed in that log file is that we first get an eth_estimateGas that fails with transaction reverted. Then we get an intrinsic gas too low error submitting the transaction itself. Finally, we start getting future transaction replaces pending errors for subsequent attempts.

This may be partly a geth bug where an intrinsic gas too low transaction doesn't reset something properly in the transaction pool state—I haven't found such a bug reported, and I'm not sure, just one hypothesis.

However, we should never submit a transaction to the chain that triggers intrinsic gas too low as an error. I'm wondering if something is happening when we get a transaction revert under eth_estimateGas in some cases that is causing us to set the gas values lower than what we know to be correct (based on base fee or block fee).