search

tahowallet / extension

Taho, the community owned and operated Web3 wallet.
https://taho.xyz
GNU General Public License v3.0
3.12k stars 392 forks source link

Support for Wallet Test Framework #3737

Closed SamWilsn closed 8 months ago

SamWilsn commented 9 months ago

Hey!

I'm one of the developers on the Wallet Test Framework project. As part of our grant from the Ethereum Foundation, we've built some integrations with wallets—Taho included.

This pull request contains the changes we needed to make to automate your wallet: adding a few id attributes, and introducing an attribute to differentiate between signing and sending a transaction. Neither myself nor @gaudren are experienced TypeScript developers, so please forgive any obvious mistakes here.

If you're curious what Taho+WTF looks like:

https://github.com/tahowallet/extension/assets/57262657/303d1df2-6458-440d-8d9e-3abbc302f720

And the glue code that makes this work: https://github.com/wallet-test-framework/glue-taho

Assuming you folks are on board, we'd like to eventually discuss integrating WTF with your testing strategy!

Latest build: extension-builds-3737 (as of Tue, 19 Mar 2024 16:33:25 GMT).

SamWilsn commented 9 months ago

does it have to be available while the skeleton loader displays?

Nope, as long as it eventually appears on the page somewhere. I'll look into that.

SamWilsn commented 8 months ago

I moved the attribute as suggested. Let me know if there's anything else you'd like to see changed!

Shadowfiend commented 8 months ago

Ah, missing secrets again. Let me see what I can do here.

Shadowfiend commented 8 months ago

Ok we're just going to see how these do on main heh.