search

tahowallet / taho.xyz

The primary website for Taho, the community owned and operated Web3 wallet.
https://taho.xyz
MIT License
52 stars 30 forks source link

Minor README Update + Create Issue : updated to tallyho.org from cash, added tip for local env #142

Open abhiram11 opened 1 year ago

abhiram11 commented 1 year ago

This PR updates the title from Tallyho.cash to the currently-known one, Tallyho.org.

Furthermore, while reproducing the dev environment on my local setup, I faced a few issues in Windows. I found it to be working on Linux machine but had errors that showed compatibility issues with node@18 and suggested downgrading to node@16, which worked for me.

I also have some minor tweaks for website optimizations, if needed I can add them as an issue and work on it as well.

A few of them are:

  1. alt attributes for most of the img tags is missing, we can add them for SEO optimizations. We should also explicitly add width and height to the images as well.
  2. We can also transform the images from PNG to web-friendly formats such as WebP and AVIF, resulting in tremendous size and speed savings as seen below on pagespeed:

tally

mhluongo commented 1 year ago

Thanks for the contribution @abhiram11! Any chance you can merge man into your branch?

@Shadowfiend can you take a peek at this when you get a minute?

abhiram11 commented 1 year ago

Hi @mhluongo , I am new to git and I did not understand how to "merge main into your branch". Were you suggesting git merge main, git rebase main, or something else? I tried the above two though.

Update 1 : I have merged main into the branch, hope it has updated as required : )

Thanks!