search

taichi-dev / taichi

Productive, portable, and performant GPU programming in Python.
https://taichi-lang.org
Apache License 2.0
25.09k stars 2.26k forks source link

Setup CPP/Python linter #2624

Open k-ye opened 2 years ago

k-ye commented 2 years ago

If possible, I'd like bots to take over my job of making comments like "add an _ suffix" 😂

Possible solution:

https://github.com/github/super-linter

bobcao3 commented 2 years ago

Is the suffix a part of chromium or Google coding style? If it is clang format should take care of it? I saw in the clang format file the based on line is commented

k-ye commented 2 years ago

Is the suffix a part of chromium or Google coding style?

Both

I saw in the clang format file the based on line is commented

Yeah, it could be because we don't follow the function naming convention in Taichi?

bobcao3 commented 2 years ago

Can we somehow override that?

On Sun, Aug 1, 2021, 9:26 PM Ye Kuang @.***> wrote:

Is the suffix a part of chromium or Google coding style?

Both

I saw in the clang format file the based on line is commented

Yeah, it could be because we don't follow the function naming convention in Taichi?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/taichi-dev/taichi/issues/2624#issuecomment-890703591, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACY7Q5H3QDG62HMCGEOSF43T2YM63ANCNFSM5BLF7TCQ .

k-ye commented 2 years ago

I believe so, but haven't really systematically learnt clang-format