search

taichi-dev / taichi_elements

High-performance multi-material continuum physics engine in Taichi
MIT License
483 stars 69 forks source link

Refactor blender addon #33

Closed PavelBlend closed 4 years ago

PavelBlend commented 4 years ago

I have divided the nodes module into parts. Also changed the names of the variables. And the question is: what to enter parameter in author?: https://github.com/taichi-dev/taichi_elements/blob/27a386830cbea36c6e63ce4251c25b75e003da3e/blender/__init__.py#L5 Maybe create a file in which to describe all the participants and write "See CONTRIBUTORS file" in the author field?

In the future there may be many participants and it will be difficult to describe all of them in this field.

And one more thing: backward compatibility is lost. But I think this is not critical, since we have not yet made a release.

yuanming-hu commented 4 years ago

Looks great! Thanks so much.

what to enter parameter in author?:

How about Taichi Elements Developers? I agree given there will be many developers in the future it's good to create a list of contributors (Either in README.md or a separate CONTRIBUTORS file) and detail who worked on what if necessary.

And one more thing: backward compatibility is lost. But I think this is not critical, since we have not yet made a release.

No worries about that for now :-) I think right now making a good node system is more important than backward compatibility.