search

taichi-dev / taichi_elements

High-performance multi-material continuum physics engine in Taichi
MIT License
489 stars 70 forks source link

tests for engine #42

Closed PavelBlend closed 4 years ago

PavelBlend commented 4 years ago

I wrote tests for the engine. I’m not sure of the correctness of the code, since the first time I write and integrate tests.

codecov-io commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d1848fd). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #42   +/-   ##
=========================================
  Coverage          ?   67.02%           
=========================================
  Files             ?        1           
  Lines             ?       94           
  Branches          ?       15           
=========================================
  Hits              ?       63           
  Misses            ?       26           
  Partials          ?        5

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d1848fd...25b0a5c. Read the comment docs.

PavelBlend commented 4 years ago

For some reason, mpm_solver.py coverage is not displayed. I do not know why this is happening.

yuanming-hu commented 4 years ago

I'm taking a look at this now...

After some investigation, I realized that I have no idea about this either. Let's merge this in for now to prevent merge conflicts in the future.

PavelBlend commented 4 years ago

Yes, you can apply them.

2. When merging PR use Squash and merge only. This will ensure linear history in master and will give us a chance to make an easy-to-understand PR title.

that is, do I need to merge branches in this way?:

git merge branch_name