search

taichi-ishitani / rggen

This repository is no longer maintained. New repository is here(https://github.com/rggen/rggen).
MIT License
16 stars 3 forks source link

Uniqe name of the bitfield #130

Open adrianf0 opened 5 years ago

adrianf0 commented 5 years ago

It's restrictive that bit fields need to have unique names in a block. If one has a sequence of control registers which provides the same functionality, it's very annoying. In the end, I think it's crucial that only whole register_name.bit_field_name is unique. Thus, could the tool enforce unique name of registers only?

taichi-ishitani commented 5 years ago

Hi @adrianf0 ,

Thank you for your feedback! I think your opinions are like below:

Is my understanding correct?

adrianf0 commented 5 years ago

That's correct.

taichi-ishitani commented 5 years ago

Thanks, I understand and agree with you. Some registers and bit fields refer other bit fields (e.g. the indirect register uses bit fields as array index). Therefore, it will take a while to implement your feedback because lookup logic need to be changed. Can you tell me priority of this feedback for you?

adrianf0 commented 5 years ago

Whenever you have time :-) Unfortunately, I can't support you in development, as the tool is written in Ruby.

taichi-ishitani commented 5 years ago

I'm refactoring RgGen tool for the next major version. I will implement your feedback (also #131 too) in the next version of RgGen. If you'd like to use the RgGen including your feedback soon, I will implement them in the current version of RgGen.

Unfortunately, I can't support you in development, as the tool is written in Ruby.

No problem. Your feedback is very useful and helps RgGen development !

taichi-ishitani commented 5 years ago

Hi @adrianf0 , I have released the latest RgGen including this feedback. (Sorry, #131 have not been implemented yet.) Could you please try to use the latest RgGen? https://github.com/rggen/rggen

I re-write RgGen so there are some differences between the latest one and the previous one. Therefore, due to differences, you need to update your configuration file and register map. For details, please see wiki document below. https://github.com/rggen/rggen/wiki