search

taichi / actions-package-update

keeps npm dependencies up-to-date by making pull requests from GitHub Actions or CI.
64 stars 14 forks source link

feat: add node version control #19

Closed Ghustavh97 closed 3 years ago

Ghustavh97 commented 3 years ago

One of my actions failed because the package updater was running on a node version that was not supported by one of the packages that was pulled by NCU (node-check-update).

This will allow the user to control which version of node they want to use when they run the action.

The current behavior locks the node version to latest which may not be ideal for certain scenarios.

The setting is optional and defaults to latest so it should not break any existing packages without the option set.

Tests: https://github.com/Ghustavh97/actions-package-update/runs/1918232749

Ghustavh97 commented 3 years ago

@taichi

taichi commented 3 years ago

merged.

Is this works for you?

Ghustavh97 commented 3 years ago

@taichi

Thanks for the merge. I tested it on my project again here and it did not work. I found the problem then fixed it here: https://github.com/taichi/actions-package-update/pull/20

Why did it fail even though my tests passed?

When I was testing my previous pull request I forgot to delete the branch that was created by actions-package-update

existing-branch

So every time I was testing it wasn't going through the whole update process because it had already created a branch with the updated packages even if I had closed the pull request.

I have fixed all the issues on my latest https://github.com/taichi/actions-package-update/pull/20 and it includes a test that has gone through the whole update process with the pull request that was created.