search

taichino / croniter

croniter is a python module to provide iteration for datetime object.
http://github.com/taichino/croniter
387 stars 105 forks source link

feat: support Python 3.6, 3.7 #130

Closed joshuarli closed 4 years ago

joshuarli commented 4 years ago

Hi! Thanks for writing croniter, we use it over at https://github.com/getsentry/sentry.

Just wanted to make sure tests pass on 3.6 + 3.7. Looks like it just works, at least in a local py37 venv. I've updated your CI config and some metadata for 2.7 and 3.4-7.

kiorky commented 4 years ago

Can you not drop python2.6 ?

kiorky commented 4 years ago

(Other things looks like LGTM)

joshuarli commented 4 years ago

Can you not drop python2.6 ?

Well, it looks like you commented 2.6 out in travis (https://github.com/taichino/croniter/commit/2da29f33764b203cba4d6b138edc42036a34899f), so I thought you meant to drop 2.6 but forgot to clean up the rest. Are you suggesting that I uncomment that and if tests still pass on 2.6, undrop 2.6?

kiorky commented 4 years ago

travis images does not support well 2.6, but we still support it here, so there is no reason to remove it from trove classifiers even if not tested by travis.

Remove the 2.6 drop and we are good to merge !

joshuarli commented 4 years ago

Oh yeah, since support for Python 3.6/7 didn't require any actual code change. Sounds good!