taiga-family / taiga-ui

Angular UI Kit and components library for awesome people
https://taiga-ui.dev
Apache License 2.0
3.27k stars 457 forks source link

🐞 - `TuiDocCodeComponent` doesn't work in Angular 16 #4606

Closed skoropadas closed 1 year ago

skoropadas commented 1 year ago

Playground Link

https://stackblitz.com/edit/stackblitz-starters-nu8bci?file=src%2Fmain.ts

Description

TuiDocCodeComponent doesn't work in Angular 16 because of ngx-highlightjs dependency that doesn't support Ivy.

Angular version

16.x.x

Taiga UI version

3.30.0

Which browsers have you used?

Which operating systems have you used?

splincode commented 1 year ago

It works https://stackblitz.com/edit/stackblitz-starters-38gjxm

skoropadas commented 1 year ago

@splincode only in your stackblitz example because it uses old angular compiler.

How to reproduce it based on your stackblitz example:

How to check that the newest version fixes it:

skoropadas commented 1 year ago

Why it can't work: 4.x.x version of the highlighter was compiled with ivy: false which mean it used ViewEngine compiler that was removed in the Angular 16. But the latest version uses partial mode that allows it to work with the Angular 16. I hope that will be enough.

splincode commented 1 year ago

@skoropadas thank you for research, we need to investigate this issue

splincode commented 1 year ago

Link: https://github.com/Tinkoff/taiga-ui/issues/3546