taiga-family / taiga-ui

Angular UI Kit and components library for awesome people
https://taiga-ui.dev
Apache License 2.0
3.27k stars 457 forks source link

🐞 - `TuiMultiSelectModule` does not export `TuiTextfieldDirective` #7461

Closed hakimio closed 1 month ago

hakimio commented 5 months ago

Playground Link

No response

Description

Unlike all the rest of Taiga input modules, TuiMultiSelectModule does not export TuiTextfieldDirective. So, if you are using ComboBox, you can do the following:

<tui-combo-box
    [formControl]="myControl"
>
    My Label
    <input
        autocomplete="new-password"
        tuiTextfield
    />
</tui-combo-box>

But the following will give you an error:

<tui-multi-select
    [formControl]="myControl"
>
    My Label
    <input
        autocomplete="new-password"
        tuiTextfield
    />
</tui-multi-select>

Angular version

17.3.8

Taiga UI version

3.77.1

Which browsers have you used?

Which operating systems have you used?

waterplea commented 5 months ago

Thanks for pointing it out. Would you be willing to make a PR into the v3 branch?

hakimio commented 5 months ago

I am quite busy right now, but might be able to take a look at this at the end of next week. If someone wants to take this before that, feel free to go ahead.

hakimio commented 5 months ago

Quickly took a look at this and it seems to me that for multi-select to accept input[tuiTextfield], input-tag template needs some major changes which include replacing simple input with primitive-textfield. If someone wants to take this, feel free to do it.

waterplea commented 5 months ago

Oh, right, it just doesn't support that at all, sorry. Seems like this will have to wait for 4.0 when all textfields will be reworked.

waterplea commented 1 month ago

I'm closing this as it would definitely be a part of specs for the refactored multi-inputs and it is not coming to legacy controls anyway.