taiga-family / taiga-ui

Angular UI Kit and components library for awesome people
https://taiga-ui.dev
Apache License 2.0
3.1k stars 408 forks source link

🐞 - v.4.0.0-rc.2 Input Phone international error #7954

Closed KhaledGabr closed 3 days ago

KhaledGabr commented 1 week ago

Playground Link

No response

Description

image

The error causes the input field not to render.

Angular version

18.0.4

Taiga UI version

4.0.0-rc.2

Which browsers have you used?

Which operating systems have you used?

waterplea commented 1 week ago

I wonder if it's because we have this:

export class TuiSelect extends TuiTextfieldDirective {

and TuiTextfieldDirective already has hostDirectives: [TuiNativeValidator, TuiAppearance],. Strange that it didn't cause issues with Angular 16 in our demo.

KhaledGabr commented 3 days ago

I am frankly not familiar with hostDirectives yet. Will need to read more about it. But for what it's worth, I had Angular 18 with Taiga 3 and the Input phone international was working there.

waterplea commented 3 days ago

This looks like a regression bug with Angular from 16 to 17, which is super bad. We'll see what can be done about it. 16: https://stackblitz.com/edit/stackblitz-starters-bwkp4z 17: https://stackblitz.com/edit/stackblitz-starters-q3mj5v

Filed an issue in the meantime: https://github.com/angular/angular/issues/56841