🐞 - Axes labels and their risks do not correlate with vertical lines and chart point

taiga-family / taiga-ui

Angular UI Kit and components library for awesome people

https://taiga-ui.dev

Apache License 2.0

3.28k stars 463 forks source link

🐞 - Axes labels and their risks do not correlate with vertical lines and chart point #8343

Open Shtoj opened 3 months ago

Shtoj commented 3 months ago

Playground Link

https://stackblitz.com/edit/angular-hfisrc?file=src%2Fapp%2Fapp.component.html

Description

The screenshots show that the label risk and the vertical line do not correspond, as does the point that should correspond to the label risk.

Angular version

12.2.17

Taiga UI version

3.88.0

Which browsers have you used?

[X] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

Which operating systems have you used?

[ ] macOS
[X] Windows
[ ] Linux
[ ] iOS
[ ] Android

waterplea commented 3 months ago

That is due to axis itself being the first line AND THEN we add the number of lines you provide. We can probably fix that getting rid of treating axis as something special and only have xxxLines/xxxLinesHandler, but that's a breaking change that needs to be carefully considered for version 5. For the time being you can just add +1 to i in your line handler.