Add data source and resource Jenkins Views

naitmare01 commented 11 months ago

This PR adds the data source and the resource jenkins_view to be able to fetch information about that component.

As of now the gojenkins doesn't fully support update on Jenkins Views.

taiidani commented 10 months ago

Hello @naitmare01! Performing a quick review -- at a glance I think the code looks valid and should work well as an addition to the provider. However, a couple things:

The provider is currently in the midst of a migration from the Provider SDKv2 to the new Plugin Framework. It requires a hefty refactor of each data source/resource. I'd be happy to perform this for you post merge but wanted to mention it if you are interested.
Before I approve, could you add acceptance tests to the new items? Example & example.

naitmare01 commented 10 months ago

Hello @taiidani !

No worries about the coming rewrite.

I have updated the PR with some tests with the best of my knowledge. First time trying that library. Let me know if they are okay?

taiidani / terraform-provider-jenkins

Add data source and resource Jenkins Views #148