search

taijinlee / wedding

wedding
0 stars 0 forks source link

Send email to any email with +, and also goes to @apricotwhisk on dev #39

Closed taijinlee closed 11 years ago

taijinlee commented 11 years ago

Roger says he'll sneak it in this release. Wooooo

ryhsiao commented 11 years ago

wait....i dont like the +.....Im only sending this to apricotwhisk right now

Logic is as follows: (1) If email has apricotwhisk in it, then we send (2) if email doesn't have apricotwhisk, then we do not send out to original email, but send to user+dev@apricotwhisk.com

ryhsiao commented 11 years ago

Done. To Taijin for review.

taijinlee commented 11 years ago

Had a tiny comment in the changeset -- tightening the requirements to @apricotwhisk.com, not just apricotwhisk (apricotwhisk@gmail.com potential?)

ryhsiao commented 11 years ago

i actually like not doing that so we can + apricotwhisk to our normal gmail accounts or send to yahoo, etc

Sent from my iPhone

On Jan 18, 2013, at 10:50 AM, Tai-Jin Lee notifications@github.com wrote:

Had a tiny comment in the changeset -- tightening the requirements to @apricotwhisk.com, not just apricotwhisk (apricotwhisk@gmail.com potential?)

— Reply to this email directly or view it on GitHub.

taijinlee commented 11 years ago

Oh ok, I didn't think about that, but that is a good point, especially for testing RSVP / other emails in other mailboxes

Does the + thing work for emails in general? or Just for gmail? But regardless, we could always create a user_apricotwhisk@yahoo.com I suppose

Tai-Jin

On Fri, Jan 18, 2013 at 11:25 AM, ryhsiao notifications@github.com wrote:

i actually like not doing that so we can + apricotwhisk to our normal gmail accounts or send to yahoo, etc

Sent from my iPhone

On Jan 18, 2013, at 10:50 AM, Tai-Jin Lee notifications@github.com wrote:

Had a tiny comment in the changeset -- tightening the requirements to @ apricotwhisk.com, not just apricotwhisk (apricotwhisk@gmail.compotential?)

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/taijinlee/wedding/issues/39#issuecomment-12437142.

taijinlee commented 11 years ago

This is done via 4d346a40d54239929adaaae2c2241d25a2222f0c after removing the console.log