Closed davidhewitt closed 2 years ago
I agree that the build scripts other than crates in the workspace should be excluded because it is never actually referenced.
Fixed in 0.3.2.
Thank you so much! I reran PyO3's main pipeline and it completed successfully: https://github.com/PyO3/pyo3/runs/6316472788?check_suite_focus=true
Looking at the coverage failure in https://github.com/PyO3/pyo3/pull/2356
I noticed that a lot of files passed as
-object
are build scripts for upstream dependencies:I guess it must be impossible for these to actually contribute to coverage? I wonder if it makes sense in
cargo-llvm-cov
to filter out these build scripts? I don't think it's as trivial as filtering all build scripts, because it would be nice to include coverage from the build scripts of crates in the workspace.