Improve support for valgrind

taiki-e / install-action

GitHub Action for installing development tools (mainly from GitHub Releases).

Apache License 2.0

248 stars 32 forks source link

Improve support for valgrind #524

Open jayvdb opened 1 month ago

jayvdb commented 1 month ago

https://formulae.brew.sh/formula/valgrind exists.

Also it looks like CI skips valgrind on the containers because snap is missing. IMO if snap is missing, using the system package for valgrind would be a good fallback.

It doesnt exist on choco yet, and https://sourceforge.net/p/valgrind4win/code/HEAD/tree/ looks dead.

taiki-e commented 1 month ago

https://formulae.brew.sh/formula/valgrind exists.

(It's x86_64 linux-only.)

IMO if snap is missing, using the system package for valgrind would be a good fallback.

That seems reasonable to me.

jayvdb commented 1 month ago

Just fyi, #526 doesnt include valgrind