search

taiki-e / install-action

GitHub Action for installing development tools (mainly from GitHub Releases).
Apache License 2.0
246 stars 32 forks source link

codegen: Remove yanked crate #549

Closed NobodyXu closed 3 weeks ago

NobodyXu commented 3 weeks ago

In the cronjob, we could check for yanked crates and remove them from this action.

taiki-e commented 3 weeks ago

While yanked versions should not be selected in the latest and omitted versions (this is already implemented), I don't think they should be disallowed from being used when explicitly specified. As far as I know, cargo is also moving in that direction: https://github.com/rust-lang/cargo/pull/13974

NobodyXu commented 3 weeks ago

Thanks, yeah I can understand that decision.

In that case, how about storing the yanked information in manifest, and then default to skip the yanked version, while allowing user to override that behavior?

taiki-e commented 3 weeks ago

default to skip the yanked version

Unless you explicitly specify the full version (tool: <tool>@<major>.<minor>.<patch>), this is already the default.

taiki-e commented 3 weeks ago

I think it is good to warn if the yanked version is explicitly selected, but I don't think we should change the version on our own.

NobodyXu commented 3 weeks ago

Thank you!