search

taiki-e / install-action

GitHub Action for installing development tools (mainly from GitHub Releases).
Apache License 2.0
246 stars 32 forks source link

Set GITHUB_TOKEN for cargo-binstall by default #556

Closed taiki-e closed 3 weeks ago

taiki-e commented 3 weeks ago

https://github.com/taiki-e/install-action/pull/554#discussion_r1649548929

The fact that cargo-binstall's performance or robustness would be worse without this env var at a high probability is very unfortunate.

cc @NobodyXu

taiki-e commented 3 weeks ago

the implicit github-token passing

Well, that's what the actions/checkout does, but it might indeed not be a good idea here.

NobodyXu commented 3 weeks ago

I will try to improve on cargo-binstall behavior, ideally users should not have to pass the github token, unless they are really installing a lot of crates or the crate itself doesn't provide any information in manifest and binstall has to figure out itself.

I think we can at least speed it up and avoid the need of token, for crate providing package.binstall with pkg-url