search

taiki-e / pin-project-lite

A lightweight version of pin-project written with declarative macros.
https://docs.rs/pin-project-lite
Apache License 2.0
226 stars 16 forks source link

Changes to clippy have broken CI on Tokio #46

Closed Darksonn closed 3 years ago

Darksonn commented 3 years ago

The Tokio master branch failed with the following error:

error: unknown clippy lint: clippy::ref_option_ref
   --> tokio/src/task/local.rs:150:1
    |
150 | / pin_project! {
151 | |     #[derive(Debug)]
152 | |     struct RunUntil<'a, F> {
153 | |         local_set: &'a LocalSet,
...   |
156 | |     }
157 | | }
    | |_^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unknown_clippy_lints
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
taiki-e commented 3 years ago

Thanks for the report! This is definitely clippy's bug (unknown_clippy_lints shouldn't warn of code generated by external macros), but I will fix it soon on the pin-project-lite side. (the same issue as https://github.com/taiki-e/pin-project/pull/303)

taiki-e commented 3 years ago

Published 0.2.3 which fixes this issue.

Darksonn commented 3 years ago

Thanks!