search

taiki-e / setup-cross-toolchain-action

GitHub Action for setup toolchains for cross compilation and cross testing for Rust.
Apache License 2.0
32 stars 3 forks source link

Support more targets #2

Open taiki-e opened 2 years ago

taiki-e commented 2 years ago

rust-cross-toolchain, on which this project is based, supports so many targets.

zeeshanlakhani commented 2 months ago

Hey @taiki-e,

I was going to add a PR to cargo-hack for it to build a release for illumos (x86_64-unknown-illumos). I see that rust-cross-toolchain already supports this, so it should be straightforward to update this action and easily run it for cargo-hack, right? I just wanted to ensure I wasn't missing something before doing the work.

Other options:

taiki-e commented 2 months ago

I see that rust-cross-toolchain already supports this, so it should be straightforward to update this action and easily run it for cargo-hack, right?

Yeah, I guess it would generally be the same as the NetBSD case, except that it does not support multiple OS versions.

Probably could be implemented by simply adding an | *-illumos* to the two lines in main.sh, and updating the CI and readme.

https://github.com/taiki-e/setup-cross-toolchain-action/blob/5512f65877f179333be1718ac2acbdb263e8e610/main.sh#L501 https://github.com/taiki-e/setup-cross-toolchain-action/blob/5512f65877f179333be1718ac2acbdb263e8e610/main.sh#L657

https://github.com/taiki-e/setup-cross-toolchain-action/blob/5512f65877f179333be1718ac2acbdb263e8e610/.github/workflows/ci.yml#L152-L155