taiki-e / upload-rust-binary-action

GitHub Action for building and uploading Rust binary to GitHub Releases.
Apache License 2.0
247 stars 22 forks source link

Support building & uploading multiple binaries at the same step #3

Closed taiki-e closed 2 years ago

taiki-e commented 3 years ago

Something like:

      - uses: taiki-e/upload-rust-binary-action@v1
        with:
          bin: bin-a,bin-b
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
joepio commented 3 years ago

Does this include support for Workspaces?

Turns out these are already supported!

taiki-e commented 3 years ago

In the virtual manifest, cargo's --bin option will search for all packages in the workspace unless there is a name conflict. So it should already be supported regardless of this issue.

In the real manifest, --bin option will only search for its package unless there is --all or --package option. So it should still be unsupported and it seems to make sense to treat it as part of this issue.

woile commented 2 years ago

Hello ppl, I'm new to rust, I've been building a small project for learning purposes, and I've been trying to publish multiple packages with no success. I've been trying to build 2 packages in the same repo, a gui and a cli, both are binaries, but I get an error. I've been using this pattern in the yaml file:

with:
  bin: 'kindle-notes-*'

My understanding is that that pattern should include only the binaries, so the lib I built would be excluded. Any ideas what I might be doing wrong? This is the repo just in case: https://github.com/Woile/kindle-notes-parser

Here's an example of that pattern failing: https://github.com/Woile/kindle-notes-parser/runs/4483667449?check_suite_focus=true

If I use kindle-notes-gui it works btw

Thanks!

taiki-e commented 2 years ago
with:
  bin: 'kindle-notes-*'

At the time, multiple binaries are not supported, so such a case will not work anyway.