search

taiki-e / upload-rust-binary-action

GitHub Action for building and uploading Rust binary to GitHub Releases.
Apache License 2.0
227 stars 19 forks source link

Build dynamic libraries with binaries #35

Open ShayBox opened 1 year ago

ShayBox commented 1 year ago

By default cargo build will build all workspace members including binaries and libraries, but this action requires adding the --bin flag which only builds binaries, can the bin option be made optional and default to normal cargo build without it?

EDIT: The include option is also a bit useless if it fails the action if it cant find a file, there may be platform dependent files such as libexample.so and example.dll but all builds fail when one of them doesn't match on one target matrix.

ShayBox commented 1 year ago

If you remove the double quotes around in the cp -r command it would allow wildcards such as *example.*, very easy way to get some versatility out of bash and would fix the second problem with include