search

taiki-e / upload-rust-binary-action

GitHub Action for building and uploading Rust binary to GitHub Releases.
Apache License 2.0
227 stars 19 forks source link

Allow specifying custom profiles #44

Closed afnanenayet closed 1 year ago

afnanenayet commented 1 year ago

Allow for users to specify a specific profile. I have a ci-specific profile, so it would be useful to be able to set a different profile in the action config.

taiki-e commented 1 year ago

Thanks for the PR!

The --profile option affect the directory from which the built binaries are output, so you have to adjust /release below.

https://github.com/taiki-e/upload-rust-binary-action/blob/609508cff1a3f2297c188c806101d75e7196b17e/main.sh#L244

https://github.com/taiki-e/upload-rust-binary-action/blob/609508cff1a3f2297c188c806101d75e7196b17e/main.sh#L251-L252

https://github.com/taiki-e/upload-rust-binary-action/blob/609508cff1a3f2297c188c806101d75e7196b17e/main.sh#L263

See this code in cargo-llvm-cov for the directory name used.

afnanenayet commented 1 year ago

Good catch, thanks

taiki-e commented 1 year ago

Published in 1.14.0.