taiki-e / upload-rust-binary-action

GitHub Action for building and uploading Rust binary to GitHub Releases.
Apache License 2.0
227 stars 19 forks source link

Align default strip behavior to Cargo 1.77+'s default #66

Closed taiki-e closed 5 months ago

taiki-e commented 5 months ago

As said in https://github.com/taiki-e/upload-rust-binary-action/issues/59, strip=debuginfo became the default behavior of Cargo 1.77+'s release build. (https://github.com/rust-lang/cargo/pull/13257)

On 1.77+, use Cargo's default (i.e., we don't set anything), and on pre-1.77, align to Cargo 1.77+'s default (set CARGO_PROFILE_RELEASE_STRIP=debuginfo).

This action was created before the strip in cargo profile was stabilized, so it required a strip on our part, we can finally remove this!

Closes #59