taikii / whiteplain

Simple and Functional Hugo theme.
https://themes.gohugo.io/whiteplain/
MIT License
132 stars 44 forks source link

Error: Deprecated DisqusShortname Prevents Site from Building in Whiteplain Hugo Theme #35

Closed robotAstray closed 2 months ago

robotAstray commented 2 months ago

Description:

While using the Whiteplain Hugo theme, I encountered an error related to the deprecated DisqusShortname. This error prevents the Hugo site from building correctly.

Steps to Reproduce:

  1. Create a Hugo site using the Whiteplain theme.

  2. Run the following command:

    hugo server --buildDraft
  3. The site fails to build, and the following error message is seen.

Error:

```
ERROR deprecated: .Site.DisqusShortname was deprecated in Hugo v0.120.0 and will be removed in Hugo 0.134.0. Use .Site.Config.Services.Disqus.Shortname instead.
Built in 12 ms
Error: error building site: logged 1 error(s)
```

Expected Behavior:

The site should build successfully without any errors. The theme should use the updated property .Site.Config.Services.Disqus.Shortname instead of the deprecated .Site.DisqusShortname.

Environment:

Proposed Solution:

Replace the deprecated .Site.DisqusShortname with .Site.Config.Services.Disqus.Shortname in the layouts/_default/single.html file.

Additional Context:

I have opened a PR to address this issue: #34

robotAstray commented 2 months ago

@taikii let me know your thoughts on this. Thank you.

taikii commented 2 months ago

@robotAstray Thank you for your PR. Sorry for the late reply. I would like to merge your PR, but I don't want to change the text color. Could you please revert style.css file change?

robotAstray commented 2 months ago

@taikii yes of course! I changed it for my work and forgot to change it back. I will fix that now.

taikii commented 2 months ago

Thank you for your great job! I have merged it.