While testing https://github.com/taikoxyz/raiko/pull/201 yesterday I wasn't testing in the PR branch, but in my own branch with some additional changes. Turns out some of these additional changes are also required to make c-kzg work correctly on SP1:
have to enable the no-threads feature in c-kzg
have to compile with -march=rv32im -mstrict-align -falign-functions=2, not just -mstrict-align
For consistency I also made risc zero compile with the same flags because normally risc zero has the same limitations (though somehow in practice not, so maybe some extra flags are enabled somehow elsewhere).
Also made it so now block 10136 is tested locally which was the block that failed before the fix (the old one didn't require the fix somehow). It's not tested on CI because the machine doesn't have enough memory. :(
While testing https://github.com/taikoxyz/raiko/pull/201 yesterday I wasn't testing in the PR branch, but in my own branch with some additional changes. Turns out some of these additional changes are also required to make c-kzg work correctly on SP1:
no-threadsfeature in c-kzg-march=rv32im -mstrict-align -falign-functions=2, not just-mstrict-alignFor consistency I also made risc zero compile with the same flags because normally risc zero has the same limitations (though somehow in practice not, so maybe some extra flags are enabled somehow elsewhere).
Also made it so now block 10136 is tested locally which was the block that failed before the fix (the old one didn't require the fix somehow). It's not tested on CI because the machine doesn't have enough memory. :(