search

taikoxyz / raiko

Multi-proofs for Taiko. SNARKS, STARKS and Trusted Execution Enclave. Our previous ZK-EVM circuits are deprecated.
Apache License 2.0
96 stars 75 forks source link

feat: prove blocks using reth #226

Closed Brechtpd closed 3 days ago

Brechtpd commented 1 month ago

reth v1.0.0-rc.2 taiko changes: https://github.com/taikoxyz/taiko-reth/pull/6 revm v36 taiko changes: https://github.com/taikoxyz/revm/pull/10

CeciliaZ030 commented 4 days ago

lgtm shouldn't be too difficult to merge the Proof of Equivalence PR

Brechtpd commented 3 days ago

LGTM! just wonder if that incorrect access list gas issue does not exist under this reth model?

Still necessary! https://github.com/taikoxyz/taiko-reth/blob/d20c700ca296f7e4227b4c8c254a8d0f948bbd36/crates/ethereum/evm/src/execute.rs#L222

smtmfft commented 3 days ago

LGTM! just wonder if that incorrect access list gas issue does not exist under this reth model?

Still necessary! https://github.com/taikoxyz/taiko-reth/blob/d20c700ca296f7e4227b4c8c254a8d0f948bbd36/crates/ethereum/evm/src/execute.rs#L222

Weird..is that a bug existed in both zeth & official reth?? I thought reth should be ok as its target is geth equivalence, should not have such a bug.

Brechtpd commented 2 days ago

Blocks don't skip invalid transactions on Ethereum, so the behavior we're triggering is taiko specific, so not a bug there.