taikoxyz / raiko

Multi-proofs for Taiko. SNARKS, STARKS and Trusted Execution Enclave. Our previous ZK-EVM circuits are deprecated.
Apache License 2.0
96 stars 75 forks source link

fix(raiko): removed panic stabilization #232

Closed 35359595 closed 3 weeks ago

35359595 commented 1 month ago

Replacing assert_eq with check_eq, which propagates error instead of panic.

Brechtpd commented 1 month ago

I think check_eq doesn't propagate the error because no error is returned? So I think this would only log there is an error but would continue execution, which would be unexpected I think.

35359595 commented 3 weeks ago

@Brechtpd Please take another look.