Tracking Sp1 cycles optimization and benchmarks

[CeciliaZ030]

The ongoing effort of optimizing sp1 cycles: https://github.com/CeciliaZ030/block-cycles/tree/master

Latest results

Before Txs

2024-06-04T10:42:40.092527Z DEBUG execute: ┌╴initialize_database    
stdout: initialize_db Account touch 496
stdout: initialize_db Storage touch 1564
2024-06-04T10:42:48.471586Z  INFO execute: └╴312,728,708 cycles    
2024-06-04T10:42:48.471737Z DEBUG execute: ┌╴prepare_header    
2024-06-04T10:42:48.472237Z  INFO execute: └╴16,184 cycles   

Typical Transfer: https://etherscan.io/tx/0x61d554e035af9bcf615818c14c725c7d0b424b806e9c7b2220380b5cf7a51b5b

2024-06-04T10:43:06.677300Z DEBUG execute: │ ┌╴Eip1559    
2024-06-04T10:43:06.677317Z DEBUG execute: │ │ ┌╴signature_hash    
2024-06-04T10:43:06.677428Z  INFO execute: │ │ └╴3,606 cycles    
2024-06-04T10:43:06.677445Z DEBUG execute: │ │ ┌╴recover_address_from_prehash    
2024-06-04T10:43:06.977910Z  INFO execute: │ │ └╴218,247 cycles    
2024-06-04T10:43:06.977942Z  INFO execute: │ └╴223,150 cycles    
2024-06-04T10:43:06.977974Z DEBUG execute: │ ┌╴evm.transact()    
2024-06-04T10:43:06.979178Z  INFO execute: │ └╴43,155 cycles  

Swap Router https://etherscan.io/tx/0x85522ad7366e195340be6c97a036d2660e0c8b87794fc7e80176ebfa37ba63b9

2024-06-04T10:42:49.303667Z DEBUG execute: │ ┌╴Eip1559    
2024-06-04T10:42:49.303684Z DEBUG execute: │ │ ┌╴signature_hash    
2024-06-04T10:42:49.303875Z  INFO execute: │ │ └╴6,166 cycles    
2024-06-04T10:42:49.303892Z DEBUG execute: │ │ ┌╴recover_address_from_prehash    
2024-06-04T10:42:49.603095Z  INFO execute: │ │ └╴218,247 cycles    
2024-06-04T10:42:49.603124Z  INFO execute: │ └╴225,710 cycles    
2024-06-04T10:42:49.603156Z DEBUG execute: │ ┌╴evm.transact()    
2024-06-04T10:42:49.643565Z  INFO execute: │ └╴1,529,795 cycles    

Bridge Approval https://etherscan.io/tx/0x0cc57a28fb31e03a2d12b07ada3efe5bfe91aaf7dc4b4f7ffa15e51c386a7428

2024-06-04T10:42:50.671066Z DEBUG execute: │ ┌╴Eip1559    
2024-06-04T10:42:50.671083Z DEBUG execute: │ │ ┌╴signature_hash    
2024-06-04T10:42:50.671510Z  INFO execute: │ │ └╴14,551 cycles    
2024-06-04T10:42:50.671528Z DEBUG execute: │ │ ┌╴recover_address_from_prehash    
2024-06-04T10:42:50.970735Z  INFO execute: │ │ └╴218,247 cycles    
2024-06-04T10:42:50.970762Z  INFO execute: │ └╴234,095 cycles    
2024-06-04T10:42:50.970797Z DEBUG execute: │ ┌╴evm.transact()    
2024-06-04T10:42:51.068495Z  INFO execute: │ └╴3,744,954 cycles 

Dependency Changes

ecdsa = { git = "https://github.com/taikoxyz/signatures.git", branch = "0.16.9", package = "ecdsa", default-features = false, features = ["der"] }

Unconstraint the recover_address_from_prehash results in 218,247 cycles

• [ ] todo: constarint this with sp1-precompile SDK's secp256 functions but it might add thousands of cycles

  revm-precompile = { git = "https://github.com/taikoxyz/revm.git", branch = "v35_taiko_v2", default-features = false, features = [
  "taiko",
  "std",
  "c-kzg",
  ] }

  Added ZkOp, see https://github.com/taikoxyz/raiko/pull/85

  Modifications for Cycle Tracking

  Some code need to be modified for printing cycles: https://succinctlabs.github.io/sp1/writing-programs/cycle-tracking.html?highlight=cycle#tracking-cycles

  raiko-lib = {  git = "https://github.com/taikoxyz/raiko.git", branch = "sp1-cycle-tracker", features = ["std", "sp1"] }

  In raiko, need to change alloy related crates:

  alloy-rpc-types = { git = "https://github.com/ceciliaz030/alloy", branch = "175_4e22b9e-cycle" }
  alloy-rpc-client = { git = "https://github.com/ceciliaz030/alloy", branch = "175_4e22b9e-cycle" }
  alloy-consensus = { git = "https://github.com/ceciliaz030/alloy", branch = "175_4e22b9e-cycle", features = [
  "serde",
  ] }
  alloy-network = { git = "https://github.com/ceciliaz030/alloy", branch = "175_4e22b9e-cycle", features = [
  "k256",
  ] }
  alloy-contract = { git = "https://github.com/ceciliaz030/alloy", branch = "175_4e22b9e-cycle" }
  alloy-eips = { git = "https://github.com/ceciliaz030/alloy", branch = "175_4e22b9e-cycle", features = [
  "serde",
  ] }
  alloy-provider = { git = "https://github.com/ceciliaz030/alloy", branch = "175_4e22b9e-cycle" }
  alloy-transport-http = { git = "https://github.com/ceciliaz030/alloy", branch = "175_4e22b9e-cycle" }
  alloy-signer = { git = "https://github.com/ceciliaz030/alloy", branch = "175_4e22b9e-cycle" }
  alloy-signer-wallet = { git = "https://github.com/ceciliaz030/alloy", branch = "175_4e22b9e-cycle" }

  Also in raiko, swap revm as well:

  revm-primitives = { git = "https://github.com/taikoxyz/revm.git", branch = "v35_taiko_v2-cycls", default-features = false }
  revm = { git = "https://github.com/taikoxyz/revm.git", branch = "v35_taiko_v2-cycls", default-features = false, features = [
  "serde",
  "std",
  "c-kzg",
  "taiko",
  ] }

Spam policy

• [X] I verify that this issue is NOT SPAM and understand SPAM issues will be closed and reported to GitHub, resulting in ACCOUNT TERMINATION.

[CeciliaZ030]

rust-kzg compiled with modification in this crate: https://github.com/CeciliaZ030/rust-kzg

• used zkcrypto backend
• added (de)serialization for writing input into guest
• can tryout Arkworks backend but still gonna cost couple of billion cycles 😅
• the best solution is to do Proof of Equivalence https://notes.ethereum.org/@dankrad/kzg_commitments_in_proofs#ZKPs-over-non-aligned-fields

performance not looking great

2024-06-12T20:25:45.908283Z DEBUG execute: ┌╴load kzg_setting    
2024-06-12T20:25:46.496903Z  INFO execute: └╴7,783,656 cycles    
2024-06-12T20:25:46.496969Z DEBUG execute: ┌╴read blob    
2024-06-12T20:25:46.557434Z  INFO execute: └╴815,690 cycles    
2024-06-12T20:25:46.557497Z DEBUG execute: ┌╴blob_to_kzg_commitment_rust    
2024-06-12T20:25:46.689752Z  INFO execute: clk = 10000000 pc = 0x2060ac    
2024-06-12T20:25:47.353332Z  INFO execute: clk = 20000000 pc = 0x218b3c    
2024-06-12T20:25:48.019065Z  INFO execute: clk = 30000000 pc = 0x20ae70    
......
024-06-12T20:34:17.819632Z  INFO execute: clk = 7700000000 pc = 0x20d8cc    
2024-06-12T20:34:17.902761Z  INFO execute: └╴7,692,653,487 cycles    

[CeciliaZ030]

compiled scep256k1 to replace k256 https://github.com/CeciliaZ030/rust-secp256k1

• use sp1_zkvm::unconstrained! to unconstraint the recovering of public key
• then impl the verification with the secp256k1 precompiles in sp1 because computation is slow but verification is fast

performance

2024-06-11T17:27:46.877028Z  INFO execute: loading memory image
2024-06-11T17:27:46.899079Z  INFO execute: starting execution
2024-06-11T17:27:46.899124Z  INFO execute: clk = 0 pc = 0x202508    
2024-06-11T17:27:46.899215Z DEBUG execute: ┌╴sign_recover    
2024-06-11T17:27:46.926345Z DEBUG execute: │ ┌╴sign    
2024-06-11T17:27:47.066870Z  INFO execute: │ └╴1,101,016 cycles    
2024-06-11T17:27:47.066959Z DEBUG execute: │ ┌╴recover    
2024-06-11T17:27:47.372553Z  INFO execute: │ └╴379,598 cycles    
2024-06-11T17:27:47.372628Z  INFO execute: └╴1,691,304 cycles    
2024-06-11T17:27:47.373276Z  INFO execute: finished execution clk = 1696694 pc = 0x0

recovering takes less than a million which is good :)