search

taikoxyz / raiko

Multi-proofs for Taiko. SNARKS, STARKS and Trusted Execution Enclave. Our previous ZK-EVM circuits are deprecated.
Apache License 2.0
96 stars 75 forks source link

fix: upgrade sp1-sdk to resolve compile issue #284

Closed kallydev closed 2 weeks ago

kallydev commented 2 weeks ago

When I was building raiko using docker according to https://github.com/taikoxyz/raiko/blob/main/docs/README_Docker_and_RA.md, I encountered an issue where the blake3-zkvm dependency could not be found. Upon investigation, I found that the upstream repository https://github.com/sp1-patches/BLAKE3 has been deleted, and the latest version of sp1 no longer depends on it.

Furthermore, the documentation specifies using the taiko/alpha-7 branch for the build. Perhaps an alpha-8 branch should be created to implement this fix?

    Updating git repository `https://github.com/sp1-patches/BLAKE3.git`
ERROR: Repository not found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
error: failed to get `blake3-zkvm` as a dependency of package `sp1-core v0.1.0 (https://github.com/succinctlabs/sp1.git?branch=main#2f57e1e7)`
    ... which satisfies git dependency `sp1-core` (locked to 0.1.0) of package `sp1-sdk v0.1.0 (https://github.com/succinctlabs/sp1.git?branch=main#2f57e1e7)`
    ... which satisfies git dependency `sp1-sdk` (locked to 0.1.0) of package `sp1-driver v0.1.0 (/Users/rustist/Developer/raiko/provers/sp1/driver)`
    ... which satisfies path dependency `sp1-driver` (locked to 0.1.0) of package `raiko-host v0.1.0 (/Users/rustist/Developer/raiko/host)`

Caused by:
  failed to load source for dependency `blake3-zkvm`

Caused by:
  Unable to update https://github.com/sp1-patches/BLAKE3.git?branch=patch-blake3_zkvm/v.1.0.0#bac2d59f

Caused by:
  failed to clone into: /Users/rustist/.cargo/git/db/blake3-551cb6a9ae540f14

Caused by:
  process didn't exit successfully: `git fetch --tags --force --update-head-ok 'https://github.com/sp1-patches/BLAKE3.git' '+refs/heads/*:refs/remotes/origin/*' '+HEAD:refs/remotes/origin/HEAD'` (exit status: 128)

This issue can be resolved by running cargo update sp1-sdk.

CeciliaZ030 commented 2 weeks ago

Thanks! this problem is fixed by commit https://github.com/taikoxyz/raiko/pull/282/commits/3b2108827b297c4b9a534d691362ad8706360957 which had been merged to main :)