fix(Risc-V toolchain): don't hardcode absolute path in /opt

taikoxyz / raiko

Multi-proofs for Taiko. SNARKS, STARKS and Trusted Execution Enclave. Our previous ZK-EVM circuits are deprecated.

Apache License 2.0

110 stars 85 forks source link

fix(Risc-V toolchain): don't hardcode absolute path in /opt #298

Open mratsim opened 3 months ago

mratsim commented 3 months ago

The installation path of riscv32-unknown-elf-gcc is distro-specific. For example in mine it's in the standard /usr/bin, instead of non-standard /opt/riscv/bin/

The standard way to make binary available regardless of physical location (local, opt, /usr/bin) is to add them to $PATH, which I assume any installer is doing.

CeciliaZ030 commented 3 months ago

you also gotta change here https://github.com/taikoxyz/raiko/blob/18bbfc93cffdeb5ff66b5f18103481b37619aa80/script/install.sh#L21 if you want to make it distro-specific :)

mratsim commented 3 months ago

For now this PR is paused, I think we need to review the install script maybe we need one for users and one for Github Actions. The current one assumes Docker and root permissions.

See https://github.com/taikoxyz/raiko/issues/299